Skip to content

feat(code-tidying): extensible source classifier for audit-dead-code - #5481

Merged
kyle-sexton merged 5 commits into
mainfrom
feat/5329-extensible-source-classifier
Sep 30, 2026
Merged

kyle-sexton merged 5 commits into
mainfrom
feat/5329-extensible-source-classifier

Conversation

@kyle-sexton

Copy link
Copy Markdown
Contributor

Closes #5329

Summary

audit-dead-code classified source files from a closed extension list, so an unreferenced .sol, .s or extensionless script was never reported as unreferenced-file and did not count in Summary coverage.

Fix

  • dc_lang_of_path reads extensions from one list, DC_NOLANE_EXTS (.s, .asm, .sol added), and classifies an extensionless file by its line-1 shebang: a shell interpreter joins the shell lane, another interpreter is a source file with no lane, no shebang is not source.
  • The grep lane counts files with no symbol lane as covered, since it checks them for references.
  • SKILL.md documents how to extend the list.
  • code-tidying 0.24.0 to 0.25.0 with a CHANGELOG entry.

Verification

  • bash plugins/code-tidying/skills/audit-dead-code/scripts/dead-code-scan.test.sh: All 274 checks passed (covers unreferenced and referenced .sol, .s and shebang scripts, and coverage counts).
  • scripts/check-changelog-parity.sh --check --check-order: passed.
  • scripts/validate-plugins.sh: all manifests and the catalog validated.

Related

🤖 Generated with Claude Code

kyle-sexton and others added 4 commits September 29, 2026 18:19
Classify source files from one DC_NOLANE_EXTS list (adds .s, .asm, .sol)
and classify extensionless files by their line-1 shebang: a shell
interpreter joins the shell lane, any other interpreter is a source file
with no lane. The grep lane now marks no-lane files covered, since it
checks them for references.

Refs #5329

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review September 29, 2026 22:31
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-29T22:34:58.968940Z ff5c9d3 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@claude

claude Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@claude

claude Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ff5c9d38c9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/code-tidying/skills/audit-dead-code/scripts/dead-code-scan.sh Outdated
… no-lane files

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@claude

claude Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@claude

claude Bot commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Claude encountered an error after 0s —— View job


I'll analyze this and get back to you.

@kyle-sexton
kyle-sexton merged commit 904a631 into main Sep 30, 2026
17 of 19 checks passed
@kyle-sexton
kyle-sexton deleted the feat/5329-extensible-source-classifier branch September 30, 2026 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

audit-dead-code: extensible source classifier for unlisted extensions and extensionless scripts

1 participant